Get baseline 100% clean coverage #1553
Merged
+1,032
−1,084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxisbey
force-pushed
the
coverage-setup
branch
from
fbd18c1 to
0972fbb
Compare
Kludex
reviewed
Oct 31, 2025
maxisbey
force-pushed
the
coverage-setup
branch
from
05f7591 to
338eb53
Compare
maxisbey
force-pushed
the
coverage-setup
branch
2 times, most recently
from
d148a88 to
9577775
Compare
maxisbey
force-pushed
the
coverage-setup
branch
from
9577775 to
c5ef006
Compare
Kinda cross but there doesn't seem to be a clean way around it
I hate this, I wish we didn't need to do this. I'll fix them later, they're now my mortal enemy.
9 tasks
Kludex
reviewed
Nov 11, 2025
Member
There was a problem hiding this comment.
I would prefer for this to be called test.
src/mcp/cli/claude.py
Outdated
| try: | ||
| config_file.write_text("{}") | ||
| except Exception: | ||
| except Exception: # pragma: no cover |
src/mcp/client/auth/oauth2.py
Outdated
| async def get_tokens(self) -> OAuthToken | None: | ||
| """Get stored tokens.""" | ||
| ... | ||
| ... # pragma: no cover |
Member
There was a problem hiding this comment.
Maybe you can add ... on the ignore rule in the pyproject.toml?
pyproject.toml
Outdated
Comment on lines
194
to
196
| exclude_also = [ | ||
| '\A(?s:.*# pragma: exclude file.*)\Z' | ||
| ] |
Member
There was a problem hiding this comment.
I would prefer if we avoid this, it seems too easy...
maxisbey
added a commit
that referenced
this pull request
Nov 11, 2025
Adds commit 89e9c43 to .git-blame-ignore-revs to exclude the large-scale addition of # pragma: no cover comments from git blame output. This commit established a 100% code coverage baseline by adding pragma comments throughout the codebase. While important for coverage tracking, these annotations are noise in git blame and should be ignored to show the original authors of substantive code changes. Github-Issue: #1553
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This adds 100% coverage by adding
# pragma: no coverin a bunch of places.This is taking over the work from #1354
Currently this PR is set to draft as it's the initial run of doing this for the whole repo. Need to get some eyes on this to make sure we're doing this right.
TODO:
# pragma: no cover's added where they shouldn't be, like if the line is actually covered I would want these removed.How Has This Been Tested?
Breaking Changes
Hopefully nothing
Types of changes
Checklist
Additional context